Audit Open Original ↗
Origin Dollar
Type
Security review
Client
Origin Protocol
Date
2020-11
Domain
Blockchain
Effort
4 wks
Section
Ethereum/EVM
Trail of Bits's security review of Origin Protocol (Nov 2020) identified 23 issues: 9 high, 1 medium, 6 low, 5 informational, and 2 undetermined.
Findings · 23
- 1 Invalid vaultBu fer could revert allocate Low
- 2 OUSD.changeSupply should require rebasingCreditsPerToken > 0 High
- 3 SafeMath is recommended in OUSD._executeTransfer Informational
- 4 Transfers could silently fail without safeTransfer Informational
- 5 Proxies are only partially EIP-1967-compliant Informational
- 6 Queued transactions cannot be canceled High
- 7 Unused code could cause problems in future Undetermined
- 8 Proposal transactions can be executed separately and block Proposal.execute call High
- 9 Proposals could allow Timelock.admin takeover High
- 10 Reentrancy and untrusted contract call in mintMultiple High
- 11 O f-by-one minDrift/maxDrift causes unexpected revert Low
- 12 Unsafe last array element removal poses future risk Undetermined
- 13 Strategy targetWeight can be set for non-existent strategy Low
- 14 Lack of minimum redeem value might lead to less return than expected Medium
- 15 withdraw allows redeemer to withdraw accidentally sent tokens Low
- 16 Variable shadowing from OUSD to ERC20 Low
- 17 VaultCore.rebase functions have no return statements Low
- 18 Multiple contracts are missing inheritances Informational
- 19 Lack of return value checks can lead to unexpected results High
- 20 External calls in loop can lead to denial of service High
- 21 No events for critical operations Informational
- 22 OUSD allows users to transfer more tokens than expected High
- 23 OUSD total supply can be arbitrary, even smaller than user balances High
Findings extracted from the published report PDF. See the full report below for details and remediation.
Related