Audit Open Original ↗
CurveDAO
Type
Security review
Client
Swiss-Stake
Date
2020-07
Domain
Blockchain
Effort
6 wks
Section
Ethereum/EVM
Trail of Bits's security review of Swiss-Stake (Jul 2020) identified 21 issues: 4 high, 8 medium, 4 low, 4 informational, and 1 undetermined.
Findings · 21
- 1 LiquidityGauge does not account for VotingEscrow’s balance updates Medium
- 2 LiquidityGauge does not account for VotingEscrow’s totalSupply updates Medium
- 3 Early users will have a unfair advantage Medium
- 4 GaugeController allows for quick vote and withdraw voting strategy Medium
- 5 Adding the same gauge multiple times will lead to incorrect sum of weights Medium
- 6 Spam attack would prevent LiquidityGauge’s integral from being updated Medium
- 7 Minter user can confiscate any user tokens High
- 8 Mint and Burn events cannot be trusted Low
- 9 VotingEscrow’s Admin can take whitelisted accounts hostage Medium
- 10 ERC20CRV is not initiated correctly with large name and symbol Low
- 11 Lack of two-step procedure for critical operations is error-prone High
- 12 Lack of value verification on decimals is error-prone Low
- 13 Lack of events is error-prone Informational
- 14 Race condition in removing addresses from whitelist and withdrawing Informational
- 15 Lack of documentation is error-prone Informational
- 16 VotingEscrow’s balanceOfAt and totalSupplyAt can return di ferent values for the same block Low
- 17 No incentive to vote early in GaugeController Medium
- 18 Several loops are not executable due to gas limitation High
- 19 Testing smart contract code in Brownie can be unreliable Undetermined
- 20 Aragon’s voting does not follow voting best practices High
- 21 Race condition may result in users earning less interest than expected Informational
Findings extracted from the published report PDF. See the full report below for details and remediation.
Related