Audit Open Original ↗
Aladdin f(x) Protocol
Type
Security review
Client
AladdinDAO
Date
2024-03
Domain
Blockchain
Effort
4 wks
Section
Ethereum/EVM
Trail of Bits's security review of AladdinDAO (Mar 2024) identified 20 issues: 4 medium, 8 low, 7 informational, and 1 undetermined.
Findings · 20
- 1 Redeeming xToken and fToken simultaneously uses incorrect TWAP price Informational
- 2 liquidatableCollateralRatio update can force liquidation without warning Low
- 3 Panicking checked arithmetic may prevent deposits and withdraws to rebalance pool Low
- 4 Incorrect TWAP price may be used for calculations such as collateral ratio Medium
- 5 Updating strategy may cause users to lose funds during redemption Medium
- 6 Time-weighted Chainlink oracle can report inaccurate price Medium
- 7 Net asset value of fractional and leverage token may reflect invalid price Low
- 8 Collateral ratio does not account underlying value of collateral in strategy Informational
- 9 Rewards are withdrawn even if protocol is not su ciently collateralized Informational
- 10 Rebalance pool withdrawal silently fails Low
- 11 Upgradeable contract initialization calls are commented out Informational
- 12 Sum of all user shares does not equal total supply Low
- 13 Lack of validation when updating system configurations Low
- 14 Lack of slippage checks prevents user from specifying acceptable loss Low
- 15 Deployments to L2 should check sequencer uptime for Chainlink price feeds Low
- 16 Treating fToken as $1 creates arbitrage opportunity and unclear incentives Informational
- 17 Rounding direction for deposits does not favor the protocol Undetermined
- 18 Reverting when minting xToken can prevent re-collateralization Medium
- 19 Unclear economic sustainability of allowing user to avoid liquidations Informational
- 20 Validation of system invariants is error prone Informational
Findings extracted from the published report PDF. See the full report below for details and remediation.
Related