Audit Open Original ↗
88mph V3
Type
Security review
Client
88mph Zefram Lou 88mph
Date
2021-08
Domain
Blockchain
Effort
6 wks
Section
Ethereum/EVM
Trail of Bits's security review of 88mph Zefram Lou 88mph (Aug 2021) identified 17 issues: 3 high, 3 medium, 2 low, 8 informational, and 1 undetermined.
Findings · 17
- 1 The interest oracle’s money market is not validated upon DInterest initialization Medium
- 2 Lack of return value check on transfer and transferFrom Informational
- 3 Lack of two-step process for contract ownership transfers Informational
- 4 Users cannot specify a minimum desired interest Medium
- 5 Withdrawing from Yearn to DInterest in a single step can save gas Informational
- 6 Linearization of exponential compounding could lead to insolvency High
- 7 Initialization functions can be front-run High
- 8 Lack of contract existence check on delegatecall Informational
- 9 Inconsistent validation of money markets’ rewards address Low
- 10 Solidity compiler optimizations can be problematic Undetermined
- 11 Redundant addition of zero value in the Harvest money market Informational
- 12 Lack of documentation concerning Rescuable base contract could result in exploitable modifications Informational
- 13 Modifications make the safeApprove function unsafe Informational
- 14 Transferring the entire balance of a contract has unintended consequences Low
- 15 Users are not informed of the pitfalls of using Yearn vaults Medium
- 16 Sponsor payout uses two transfers when only one is required Informational
- 17 ERC20Wrapper’s transferFrom function ignores the sender argument High
Findings extracted from the published report PDF. See the full report below for details and remediation.
Related